Enhancement: Cache array, object, gradual feeding#402
Open
utf4 wants to merge 1 commit intoplatanus:masterfrom
Open
Enhancement: Cache array, object, gradual feeding#402utf4 wants to merge 1 commit intoplatanus:masterfrom
utf4 wants to merge 1 commit intoplatanus:masterfrom
Conversation
monkeyci
reviewed
Nov 11, 2016
| }); | ||
|
|
||
| it('should return false if passed data is invalid', function() { | ||
| var ret = packerCache.feed('bikes', "Invalid"); |
monkeyci
reviewed
Nov 11, 2016
|
|
||
| it('should feed array is passed after object', function() { | ||
| packerCache.feed('bikes', { id: 11, model: 'Banana' }); | ||
| packerCache.feed('bikes', [ { id: 12, model: 'Apple' }, { id: 13, model: 'Mango' } ]); |
monkeyci
reviewed
Nov 11, 2016
| }); | ||
|
|
||
| it('should feed object is passed after array', function() { | ||
| packerCache.feed('bikes', [ { id: 8, model: 'Apple' }, { id: 9, model: 'Mango' } ]); |
monkeyci
reviewed
Nov 11, 2016
|
|
||
| it('should feed array is passed after array', function() { | ||
| packerCache.feed('bikes', [ { id: 4, model: 'Apple' }, { id: 5, model: 'Mango' } ]); | ||
| packerCache.feed('bikes', [ { id: 6, model: 'Banana' }, { id: 7, model: 'Dates' } ]); |
monkeyci
reviewed
Nov 11, 2016
| }); | ||
|
|
||
| it('should feed array is passed after array', function() { | ||
| packerCache.feed('bikes', [ { id: 4, model: 'Apple' }, { id: 5, model: 'Mango' } ]); |
monkeyci
reviewed
Nov 11, 2016
| }); | ||
|
|
||
| it('should feed data if passed as array at start', function() { | ||
| packerCache.feed('bikes', [ { id: 1, model: 'Meta' }, { id: 2, model: 'Slash' } ]); |
monkeyci
reviewed
Nov 11, 2016
|
|
||
| it('shouldnt fail if packer not initialized', function() { | ||
| expect(function() { | ||
| packerCache.feed("test", []); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working on jsonapi.org strict standard and that is sending everything in included:{} element, which need object and gradual cache feeding. Please have a look and see if this can be mergable or suggest any improvements.